michaelplatings added inline comments.
Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49
+// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s
-### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV
+//
bryanpkc added inline comments.
Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49
+// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s
-### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV
+// SME-SUBFEATURE-CONFLICT-REV:
MaskRay added inline comments.
Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49
+// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s
-### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV
+// SME-SUBFEATURE-CONFLICT-REV:
michaelplatings added inline comments.
Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49
+// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s
-### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV
+//
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2c38740ca661: [Clang][AArch64][SME] Generate target features
from +(no)sme.* options (authored by bryanpkc).
Repository:
rG LLVM Github Monorepo
bryanpkc updated this revision to Diff 540842.
bryanpkc marked an inline comment as done.
bryanpkc added a comment.
Removed dependency on SVE and SVE2 as per @sdesmalen's suggestion. Also made
`nobf16` imply `nosme` to be consistent with the handling of other feature
dependencies.
Repository:
sdesmalen added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:87-90
+if (Feature == "sme") {
+ Features.push_back("+sve");
+ Features.push_back("+sve2");
+ Features.push_back("+bf16");
SME shouldn't require SVE or
bryanpkc updated this revision to Diff 528293.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142702/new/
https://reviews.llvm.org/D142702
Files:
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
clang/test/Driver/aarch64-implied-sme-features.c
bryanpkc created this revision.
bryanpkc added reviewers: sdesmalen, rsandifo-arm, david-arm.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
bryanpkc requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
