[PATCH] D143386: Add function pointer alignment to DataLayout

efriedma added a comment. In D143386#4110398 , @gchatelet wrote: >> And the x86 doesn't specify 4-byte alignment. > > I thought that specifying it in the `DataLayout` would help getting rid of > the special handling in ConstantFold >

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet added a comment. Herald added a subscriber: jobnoorman. In D143386#4107144 , @efriedma wrote: > Almost all the specifications you're specifying are wrong. Very few targets > should be using "i". Off the top of my head, 32-bit ARM, MIPS

[PATCH] D143386: Add function pointer alignment to DataLayout

efriedma added a comment. Almost all the specifications you're specifying are wrong. Very few targets should be using "i". Off the top of my head, 32-bit ARM, MIPS targets with MicroMIPS, and certain PowerPC targets should, but most common targets shouldn't. ("i" means that either the

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet created this revision. gchatelet added a reviewer: efriedma. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,