[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir abandoned this revision. Amir added a comment. Migrated to https://github.com/llvm/llvm-project/pull/69133 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542280. Amir added a comment. Make the name of BOLT-instrumented Clang binary (CLANG_BOLT_INSTRUMENTED) a user-settable cache variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542272. Amir added a comment. Set CLANG_BOLT_INSTRUMENTED in parent scope too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542264. Amir marked an inline comment as done. Amir added a comment. Fix instrumentation mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files:

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir marked 7 inline comments as done. Amir added inline comments. Comment at: clang/utils/perf-training/perf-helper.py:75 +parser.add_argument( +"--lbr", required=False, action="store_true", help="Use perf with branch stacks" +) phosek wrote: >

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542060. Amir added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

phosek added inline comments. Comment at: clang/utils/perf-training/bolt.lit.cfg:12 +if config.clang_bolt_mode.lower() == "instrument": +clang_binary = "clang-bolt.inst" +else: # perf or LBR This name would ideally be passed through the generated

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 538271. Amir added a comment. Rebase + reformatted with `black` (D150761 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files:

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir added a comment. Ping @beanz, @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 521919. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 504392. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496276. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496273. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496272. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496271. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496253. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake