[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG235e90c1d760: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496680. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clang/AST/Type.h

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2052 + Diag(Loc, diag::err_riscv_type_requires_extension, FD) + << Ty << "experimental-zvfh"; +} experimental- is an internal naming scheme. "experimental-" is not used in

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496382. eopXD added a comment. Update code: use a more scalable way to check for RVV type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files:

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496311. eopXD added a comment. Update code based on comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clang/AST/Type.h

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496183. eopXD added a comment. Update code: check for `experimental-zvfh` instead of `zvfh`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files:

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496160. eopXD added a comment. Update code: rename error for vector support, remove dead code under SemaRISCVVectorLoopup.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD added a comment. Forward declaration (snippet below) is still allowed after this commit. #include vfloat16m1_t foo(); I see the same behavior under https://github.com/llvm/llvm-project/blob/main/clang/test/Sema/x86_64-no-x87.cpp. If I add type check under

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD added a comment. In D143657#4115721 , @craig.topper wrote: > Are you going to do f32, f64, and i64 as well? Yes, going to add them once this commit lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

craig.topper added a comment. Are you going to do f32, f64, and i64 as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 ___ cfe-commits mailing list