[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG997dc7e00f49: [debug-info][codegen] Prevent creation of self-referential SP node (authored by fdeazeve). Repository: rG LLVM Github Monorepo

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve updated this revision to Diff 497713. fdeazeve added a comment. Fixed clang format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl accepted this revision. aprantl added a comment. Test looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 ___ cfe-commits mailing list

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. In D143921#4124533 , @aprantl wrote: > In D143921#4123218 , @fdeazeve > wrote: > >> Any testing suggestions here? I can use what we have on GH (cpp -> codegen >> test), but I'm not

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve updated this revision to Diff 497321. fdeazeve added a comment. Added verifier test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl added a comment. In D143921#4123218 , @fdeazeve wrote: > Any testing suggestions here? I can use what we have on GH (cpp -> codegen > test), but I'm not sure if there's a finer grained test we could use. I was thinking of a very small IR test

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/IR/Verifier.cpp:1404 +CheckDI(!N.getRawDeclaration(), +"subprogram declaration must not have a declaration field"); }

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. Any testing suggestions here? I can use what we have on GH (cpp -> codegen test), but I'm not sure if there's a finer grained test we could use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. fdeazeve requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The