[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

In D143996#4147759 , @bjosv wrote:

> @carlosgalvezp Sorry, I should have mentioned that I don't have push rights 
> and that this is my first contribution to llvm.
> My GitHub user is:  bjosv   and email:  bjorn.a.svens...@est.tech
> Thanks.

No problem, thanks for your first contribution! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Carlos Galvez via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG2928746ac3f1: [clang-tidy][doc] Remove unused variable 
(authored by bjosv, committed by carlosgalvezp).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

Files:
  
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst


Index: 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
-``c_reference``, will all generate warnings since they are either:
-a globally accessible variable and non-const, a pointer or reference providing
-global access to non-const data or both.
+The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference``
+will all generate warnings since they are either a non-const globally 
accessible
+variable, a pointer or a reference providing global access to non-const data
+or both.


Index: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
-``c_reference``, will all generate warnings since they are either:
-a globally accessible variable and non-const, a pointer or reference providing
-global access to non-const data or both.
+The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference``
+will all generate warnings since they are either a non-const globally accessible
+variable, a pointer or a reference providing global access to non-const data
+or both.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Björn Svensson via Phabricator via cfe-commits]

bjosv added a comment.

@carlosgalvezp Sorry, I should have mentioned that I don't have push rights and 
that this is my first contribution.
My GitHub user is:  bjosv   and email:  bjorn.a.svens...@est.tech
Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

@bjosv Are you able to land the land yourself, or should we do it for you? If 
so, please provide user and email for Github attribution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp accepted this revision.
carlosgalvezp added a comment.

LGTM, thanks for the fix!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Björn Svensson via Phabricator via cfe-commits]

bjosv updated this revision to Diff 497344.
bjosv added a comment.

Updated to fill 80 char as proposed, and changed some wordings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

Files:
  
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst


Index: 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
-``c_reference``, will all generate warnings since they are either:
-a globally accessible variable and non-const, a pointer or reference providing
-global access to non-const data or both.
+The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference``
+will all generate warnings since they are either a non-const globally 
accessible
+variable, a pointer or a reference providing global access to non-const data
+or both.


Index: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
-``c_reference``, will all generate warnings since they are either:
-a globally accessible variable and non-const, a pointer or reference providing
-global access to non-const data or both.
+The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference``
+will all generate warnings since they are either a non-const globally accessible
+variable, a pointer or a reference providing global access to non-const data
+or both.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko requested changes to this revision.
Eugene.Zelenko added inline comments.
This revision now requires changes to proceed.



Comment at: 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst:35
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
+Variables: ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and
 ``c_reference``, will all generate warnings since they are either:

Please fill as much of 80 symbols as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143996/new/

https://reviews.llvm.org/D143996

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

[Björn Svensson via Phabricator via cfe-commits]

bjosv created this revision.
Herald added subscribers: kbarton, xazax.hun, nemanjai.
Herald added a reviewer: njames93.
Herald added a project: All.
bjosv requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Remove mention of a variable that is not used in the example for checker:
cppcoreguidelines-avoid-non-const-global-variables


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143996

Files:
  
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst


Index: 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ 
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
+Variables: ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and
 ``c_reference``, will all generate warnings since they are either:
 a globally accessible variable and non-const, a pointer or reference providing
 global access to non-const data or both.


Index: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
+++ clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
@@ -32,7 +32,7 @@
 char h = 0;
 };
 
-Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and
+Variables: ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and
 ``c_reference``, will all generate warnings since they are either:
 a globally accessible variable and non-const, a pointer or reference providing
 global access to non-const data or both.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits