This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cb6e476ccaa: [clang][Interp] Handle PtrMemOps (authored by
tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LG!
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234
+ if (!LT || !RT || !T)
+return this->bail(BO);
tbaeder wrote:
>
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234
+ if (!LT || !RT || !T)
+return this->bail(BO);
aaron.ballman wrote:
> Should we be checking `!T` earlier (it's used within the `Discard` lambda
> with an unprotected
tbaeder updated this revision to Diff 542762.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Context.cpp
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214
+ if (BO->isPtrMemOp())
+return this->visit(RHS);
+
tbaeder wrote:
> aaron.ballman wrote:
> > tbaeder wrote:
> > > aaron.ballman wrote:
> > > > Do we need
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214
+ if (BO->isPtrMemOp())
+return this->visit(RHS);
+
aaron.ballman wrote:
> tbaeder wrote:
> > aaron.ballman wrote:
> > >
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214
+ if (BO->isPtrMemOp())
+return this->visit(RHS);
+
tbaeder wrote:
> aaron.ballman wrote:
> > Do we need similar changes for unary operators, pointer
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214
+ if (BO->isPtrMemOp())
+return this->visit(RHS);
+
aaron.ballman wrote:
> Do we need similar changes for unary operators, pointer arithmetic operators,
> etc?
In
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234
+ if (!LT || !RT || !T)
+return this->bail(BO);
Should we be checking `!T` earlier (it's used within the `Discard` lambda with
an unprotected dereference)?
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214
+ if (BO->isPtrMemOp())
+return this->visit(RHS);
+
Do we need similar changes for unary operators, pointer arithmetic operators,
etc?
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 527346.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Context.cpp
clang/lib/AST/Interp/Interp.h
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Context.cpp:122
+ T->isFunctionProtoType() ||
+ T->isSpecificBuiltinType(BuiltinType::BoundMember))
+return PT_FnPtr;
aaron.ballman wrote:
> Do you have test coverage for the bound
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Context.cpp:122
+ T->isFunctionProtoType() ||
+ T->isSpecificBuiltinType(BuiltinType::BoundMember))
+return PT_FnPtr;
Do you have test coverage for the bound member case?
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144164/new/
https://reviews.llvm.org/D144164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a result of the discussions in
27 matches
Mail list logo
