[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D144179#4166909 , @mgabka wrote: > In D144179#4146599 , @MaskRay wrote: > >> This looks like

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

mgabka added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your user

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 501428. jolanta.jensen added a comment. Test adjustment for Windows. Disabling read permissions using chmod does not seem to work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 500747. jolanta.jensen added a comment. Adjusting the test for Windows. Setting the read bits only for the config file as Windows does not have full support for chmod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay added a comment. This looks like introducing a footgun (when something behaves differently from an upstream Clang, it would be difficult for toolchain maintainers to know why). Why can't your user specify `CLANG_CONFIG_FILE_SYSTEM_DIR`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499502. jolanta.jensen added a comment. Adjusting the test for Windows OS again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499101. jolanta.jensen added a comment. Adjusted the test for Windows OS. Once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4132597 , @MaskRay wrote: > Behaviors due to a new environment variable should be very careful. How is > this useful? If you want this, you can add a wrapper around `clang` to > specify `--config=` by

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 498826. jolanta.jensen added a comment. Extended the test to cover Windows OS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay added a comment. Behaviors due to a new environment variable should be very careful. Why is this useful? If you want this, you can add a wrapper around `clang` to specify `--config=` by yourself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen created this revision. jolanta.jensen added reviewers: mgabka, huntergr, david-arm. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also added functionality to set the name