[PATCH] D144590: Fix shared memory allocation on AMDGPU

2023-02-22 Thread Nuno Lopes via Phabricator via cfe-commits
nlopes added a comment. Please use poison values as place holders instead of undef values as we're trying to get rid of Undef. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144590/new/ https://reviews.llvm.org/D144590

[PATCH] D144590: Fix shared memory allocation on AMDGPU

2023-02-22 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I think this looks reasonable to me. @jdoerfert WDYT? I'm not sure if you need to fix some clang tests. Let's see if Buildbot is happy. Repository: rG LLVM Github Monorepo

[PATCH] D144590: Fix shared memory allocation on AMDGPU

2023-02-22 Thread Zane Fink via Phabricator via cfe-commits
ZwFink added a comment. Full details and reproducer at this GitHub issue: https://github.com/llvm/llvm-project/issues/60345 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144590/new/ https://reviews.llvm.org/D144590

[PATCH] D144590: Fix shared memory allocation on AMDGPU

2023-02-22 Thread Zane Fink via Phabricator via cfe-commits
ZwFink created this revision. Herald added subscribers: nlopes, kosarev, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. ZwFink requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo