[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits added a comment. In D145069#4191046 , @xazax.hun wrote: > Do you plan to selectively enable warnings coming from the STL to catch > misuses of certain STL types? No. At first when we have found out that the Static Analyzer can reason about

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

xazax.hun added a comment. Do you plan to selectively enable warnings coming from the STL to catch misuses of certain STL types? I think we should probably discuss this direction first. It is, in general, a fragile approach. Users might use Clang with GCC's, LLVM's, or MSVC's standard

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:449 // No diagnostic if region was modified inside the frame. if (!CallExitLoc || isModifiedInFrame(N)) return nullptr; We also lost this,

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits updated this revision to Diff 504062. spaits added a comment. As @Szelethus has mentioned in his reply I tried to improve on the comment. I hope now it describes correctly what the new visitor is good for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

Szelethus added a comment. We worked on this together, so I waited a bit for others to have a say in this, but this design seems like a no brainer to me. Please fix those comments, otherwise LGTM. Also, while the patch is LGTM (moving code around is okay), the comment says "system headers

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits created this revision. spaits added reviewers: NoQ, steakhal, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. spaits requested review of this revision.