Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-16 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253207: Handle ARMv6KZ naming (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14570?vs=39901=40280#toc Repository: rL LLVM http://reviews.llvm.org/D14570 Files:

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-16 Thread James Molloy via cfe-commits
Hi Renato, Ideally, shouldn't the clang tests be checking that the LLVM target parsing library is called with the correct arguments? then separate tests inside LLVM check that the target parser works correctly? As it stands, it seems like a very deliberate layering violation that could really do

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-12 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. The specific CPU was only chosen to match what the backend supported at the time. As long as the feature set is identical, it doesn't really matter. http://reviews.llvm.org/D14570 ___ cfe-commits mailing list

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-12 Thread A. Skrobov via cfe-commits
tyomitch added a comment. In http://reviews.llvm.org/D14570#288022, @joerg wrote: > The specific CPU was only chosen to match what the backend supported at the > time. As long as the feature set is identical, it doesn't really matter. The feature set isn't quite identical; default ARMv6 CPU

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Wow, this is tricky: the code change is in LLVM, and test change in clang :(. However, this does seem to

RE: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-11 Thread Artyom Skrobov via cfe-commits
den Cc: kanh...@a-bix.com; cfe-commits@lists.llvm.org Subject: Re: [PATCH] D14570: Handle ARMv6KZ naming Hi Artyom, Why isn't this just part of D14568? Cheers, James On Wed, 11 Nov 2015 at 12:08 A. Skrobov via cfe-commits <cfe-commits@lists.llvm.org> wrote: tyomitc

[PATCH] D14570: Handle ARMv6KZ naming

2015-11-11 Thread A. Skrobov via cfe-commits
tyomitch created this revision. tyomitch added reviewers: rengolin, joerg, bogden. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Update for clang tests for D14568 http://reviews.llvm.org/D14570 Files: test/Driver/arm-cortex-cpus.c

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-11 Thread James Molloy via cfe-commits
Hi Artyom, Why isn't this just part of D14568? Cheers, James On Wed, 11 Nov 2015 at 12:08 A. Skrobov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tyomitch created this revision. > tyomitch added reviewers: rengolin, joerg, bogden. > tyomitch added a subscriber: cfe-commits. > Herald