[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acdf58919d5: [clang] Properly parse variable template requires clause in lambda (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 506121. rymiel added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. In D146140#4201481 , @cor3ntin wrote: > Do we need a release note for this? Yes, good catch! @rymiel : can you please add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

cor3ntin added a comment. Do we need a release note for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing list

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. In D146140#4196919 , @rymiel wrote: > In D146140#4196886 , @erichkeane > wrote: > >> Ah, also, before commit, ensure that pre-commit CI passes. > > Yep, found an issue already ;; > >

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added a comment. In D146140#4196886 , @erichkeane wrote: > Ah, also, before commit, ensure that pre-commit CI passes. Yep, found an issue already ;; In D146140#4196866 , @erichkeane wrote: > I presume

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505534. rymiel added a comment. Use dyn_cast_if_present, otherwise we segfault in some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files:

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. Ah, also, before commit, ensure that pre-commit CI passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thank you! This looks good to me. I presume you don't have commit access, so if you give me your "SomeName ", I can commit this for you. Repository: rG LLVM Github Monorepo

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1283 ParseScope LambdaScope(this, Scope::LambdaScope | Scope::DeclScope | Scope::FunctionDeclarationScope |

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505525. rymiel added a comment. utilize getCurFunction() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1283 ParseScope LambdaScope(this, Scope::LambdaScope | Scope::DeclScope | Scope::FunctionDeclarationScope | Ok, last bit, I promise :) I see

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) &&

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505499. rymiel added a comment. Slightly rewrite CheckForNonPrimary for slightly better clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files:

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel created this revision. rymiel added a project: clang. rymiel added reviewers: aaron.ballman, erichkeane. Herald added a project: All. rymiel requested review of this revision. Herald added a subscriber: cfe-commits. Since P0857, part of C++20, a *lambda-expression* can contain a