[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked an inline comment as done. Closed by commit rG0eb06cb3aa27: [Sema] Stop stripping CV quals from *this captures in lambdas (authored by royjacobson).

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson marked an inline comment as done. royjacobson added a comment. In D146168#4231457 , @aaron.ballman wrote: > LGTM aside from a minor nit, though I have some minor concerns that we may > silently break people's code by calling different

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 509436. royjacobson added a comment. fix unintended indentation & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor nit, though I have some minor concerns that we may silently break people's code by calling different overloads or instantiating templates differently so I wonder if this is a potentially breaking change

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 506295. royjacobson added a comment. Add the test case from the GH issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

shafik added a comment. Can we also add the test from the bug report as a regression test, it looks like the existing test are basically covering the same thing but I have seen stranger bugs so it would be good to explicitly cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

cor3ntin added subscribers: hubert.reinterpretcast, cor3ntin. cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Triple checking with @hubert.reinterpretcast for conformance but I'm pretty sure that's correct. Repository: rG LLVM

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

shafik added a comment. Can you add a summary, I realize folks can goto the release notes edit and see the bug report and then go look it up but at least a cursory summary is a little more reviewer friendly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 505624. royjacobson added a comment. rebase + release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146168 Files: clang/lib/Sema/SemaExprCXX.cpp