[PATCH] D146328: [clang][deps] Only cache files with specific extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e00b6f136e: [clang][deps] Only cache files with specific extension (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese accepted this revision. Bigcheese added a comment. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 ___ cfe-commits mailing list

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506242. jansvoboda11 added a comment. Improve member documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506241. jansvoboda11 added a comment. Disable brace initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506240. jansvoboda11 added a comment. Use brace initialization in named constructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/ https://reviews.llvm.org/D146328 Files:

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506237. jansvoboda11 added a comment. Herald added a subscriber: ormris. Use named constructors instead of an argument to `PathPolicy`, add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:272-291 +enum class Enable { Yes, No }; +enum class ScanFile { Yes, No }; +enum class CacheStatFailure { Yes, No }; + +struct PathPolicy { + unsigned

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 updated this revision to Diff 506205. jansvoboda11 added a comment. Remove configurable `CacheSuccess`, rename `CacheFailure` to `CacheStatFailure`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146328/new/

[PATCH] D146328: [clang][deps] Only cache files with specific extension

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. This doesn't appear to behave as expected for `PP_CacheFailure` or `PP_ScanFile` without `PP_CacheSuccess`. Looks like that will still cache. Should probably just assert that's not the

[PATCH] D146328: [clang][deps] Only cache files with specific extension

ributzka added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161 -/// Whitelist file extensions that should be minimized, treating no extension as -/// a source file that should be minimized. +/// Whitelist file extensions

[PATCH] D146328: [clang][deps] Only cache files with specific extension

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the scanner's VFS,