[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added a comment. Thank you, @aaron.ballman and @tahonermann for your comments! This was committed to https://github.com/llvm/llvm-project.git with hash 6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 CHANGES SINCE LAST

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Changes look good to me. Thanks, Sindhu! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:91 /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4;

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:91 /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4;

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507964. schittir added a comment. Changed CodeObjectVersion default to COV_None CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index:

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:48 /// The EABI version to use - llvm::EABI EABIVersion; + llvm::EABI EABIVersion = llvm::EABI::Default; Looks good; this is consistent with the default

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507425. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index: clang/include/clang/Basic/TargetOptions.h

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5890-5892 + TargetOpts.EABIVersion = llvm::EABI::Default; + // Initialize CodeObjectVersion with default i.e., 4 + TargetOpts.CodeObjectVersion = TargetOptions::CodeObjectVersionKind::COV_4;

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir created this revision. schittir added reviewers: tahonermann, shafik. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by Coverity static analysis tool. Repository: rG LLVM Github