michaelplatings updated this revision to Diff 518997.
michaelplatings added a comment.
Chagne code to allow defining multilib flags verbatim
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146757/new/
https://reviews.llvm.org/D146757
Files:
michaelplatings added inline comments.
Comment at: clang/include/clang/Driver/Multilib.h:58
+ StringRef IncludeSuffix = {}, const flags_list =
flags_list(),
+ PrintOptionsType PrintOptions = PrintOptionsType::PlusFlags,
+ const flags_list =
michaelplatings updated this revision to Diff 511073.
michaelplatings marked 3 inline comments as done.
michaelplatings added a comment.
Expand constructor comment as suggested by @peter.smith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
peter.smith added a comment.
Approach looks good to me. Some suggestions, mostly around documenting the
interface.
Comment at: clang/include/clang/Driver/Multilib.h:56
/// This is enforced with an assert in the constructor.
Multilib(StringRef GCCSuffix = {}, StringRef
michaelplatings added a comment.
@phosek ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146757/new/
https://reviews.llvm.org/D146757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Sometimes it's necessary to define a multilib in terms of
