[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3b919a5e01ef: [clang-tidy] Fix example provided by add_new_check.py (authored by PiotrZSL). Repository: rG LLVM Github

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509412. PiotrZSL added a comment. Remove added -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files: clang-tools-extra/clang-tidy/add_new_check.py Index:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509411. PiotrZSL added a comment. Remove change added by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 509410. PiotrZSL added a comment. Move fix from note to warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

njames93 added a comment. In D146875#4229544 , @carlosgalvezp wrote: > I think easiest is to go for Option A) - this is how we normally write checks > nowadays. Maybe the discussion about removing support for `--fix-notes` can > be done in an RFC?

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL added a comment. Ok, lets do that, I will change this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 ___ cfe-commits mailing list

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

carlosgalvezp added a comment. Thanks for digging into this! It looks a bit strange to me: > Usually developers have to preview a code diff (before vs after apply the > fix) to understand what the fix does before applying a fix. This is not quite true - clang-tidy displays the fix it hint when

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL added a comment. I know that it would be better, best would be to remove that --fix-notes completely and enable those notes fixes with basic --fix, as it only create confusion. Originally it were like this: "Added an option to control whether to apply the fixes found in notes attached

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:278 with io.open(filename, 'w', encoding='utf8', newline='\n') as f: -f.write("""// RUN: %%check_clang_tidy %%s %(check_name_dashes)s %%t +f.write("""// RUN:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 508315. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Added issue reference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently test for