This revision was automatically updated to reflect the committed changes.
Closed by commit rG26ff268b80c5: [include-cleaner] Report references to
operator calls as implicit (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein accepted this revision.
hokein added a comment.
still LG.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147144/new/
https://reviews.llvm.org/D147144
___
cfe-commits mailing list
kadircet updated this revision to Diff 510474.
kadircet marked an inline comment as done.
kadircet added a comment.
- Update to treat operator calls to members as "explicit" fater offline
discussions. This better aligns with what we do for regular member exprs.
Repository:
rG LLVM Github
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:98
return false;
-
-// Operators are always ADL extension points, by design references to them
-
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Missing these references can result in false negatives in the used-ness
