This revision was automatically updated to reflect the committed changes.
Closed by commit rG0cc66f3c779b: [Windows SEH] Fix catch+return crash for
Windows -EHa (authored by pengfei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147165/new/
LuoYuanke accepted this revision.
LuoYuanke added a comment.
This revision is now accepted and ready to land.
LGTM, pls wait for 1 or 2 days in case there are comments from others
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147165/new/
pengfei added a comment.
I checked no difference in codegen between `/EHa` and `/EHsc` in MSVC. So it
should be correct for clang as well.
We should land it ASAP since it fixes a crash case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
pengfei created this revision.
pengfei added reviewers: tentzen, efriedma, victork1996.
Herald added subscribers: kbarton, nemanjai.
Herald added a project: All.
pengfei requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
This change
