This revision was automatically updated to reflect the committed changes.
Closed by commit rGe51f46705e28: [clang-tidy] ignore NRVO const variables in
performance-no-automatic-move. (authored by gnanabit, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
gnanabit updated this revision to Diff 510532.
gnanabit added a comment.
Add release notes entry.
Thanks for the reviews! Happy to reword the release notes if they are unclear.
@courbet or @PiotrZSL, I don't have commit access. Can you land this patch for
me? Please use "Logan Gnanapragasam
PiotrZSL added a comment.
Add release notes entry !.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147419/new/
https://reviews.llvm.org/D147419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
PiotrZSL accepted this revision.
PiotrZSL added a comment.
Current change is correct.
This check could be improved in future.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147419/new/
https://reviews.llvm.org/D147419
courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.
Thanks for the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147419/new/
https://reviews.llvm.org/D147419
gnanabit updated this revision to Diff 510374.
gnanabit added a comment.
Fix typo in `CHECK-MESSAGES` (should warn about `obj2`, not `obj1`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147419/new/
https://reviews.llvm.org/D147419
Files:
gnanabit created this revision.
gnanabit added a reviewer: courbet.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
gnanabit requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a
