[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

aras-p added a comment. This is probably obsolete now that D148410 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147520/new/ https://reviews.llvm.org/D147520

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Gentle ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147520/new/ https://reviews.llvm.org/D147520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Analysis the issue using the above simple example: When clang parses the first line (`#include "1.h"`) in the `main.cpp`, a time section entry is created and put on the top of the time-trace stack. Assuming this time section entry is named `Source-1.h`, which has its

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. A simple test to reproduce the issue: % cat main.cpp #include "1.h" #include "2.h" int foo(); % cat 1.h template auto Zero() -> T { return T{}; } %cat 2.h struct Bla {}; Compile the code with `-ftime-trace-granularity=0 -ftime-trace` to show the

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi created this revision. MaggieYi added reviewers: Whitney, jamieschmeiser, MaskRay, rnk, aras-p, anton-afanasyev. Herald added a subscriber: hiraditya. Herald added a project: All. MaggieYi requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: