[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 closed this revision. doru1004 added a comment. Commit: 01910787d386584ea5a3d5dc317a908423ba39ed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM unless anyone else has any concerns. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 511444. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp Index:

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 511436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp Index:

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jhuber6 wrote: > jdoerfert wrote: > > doru1004 wrote: > > >

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jdoerfert wrote: > doru1004 wrote: > > jhuber6 wrote: > > >

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. doru1004 wrote: > jhuber6 wrote: > > Shouldn't the Nvidia

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. jhuber6 wrote: > Shouldn't the Nvidia version also be

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. Shouldn't the Nvidia version also be undefined? Not sure why

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 510943. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/target_team_variable_codegen.cpp

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:303 +if (GV->hasInitializer() && !(isa(GV->getInitializer()) || + isa(GV->getInitializer( { OutContext.reportError({}, arsenm

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:303 +if (GV->hasInitializer() && !(isa(GV->getInitializer()) || + isa(GV->getInitializer( { OutContext.reportError({}, Isa

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 marked an inline comment as done. doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3355 +llvm::GlobalValue::InternalLinkage, +CGM.getTriple().isAMDGCN() ? llvm::UndefValue::get(VarTy) +

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 updated this revision to Diff 510934. Herald added subscribers: llvm-commits, kosarev, foad, kerbowa, hiraditya, jvesely, arsenm. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3355 +llvm::GlobalValue::InternalLinkage, +CGM.getTriple().isAMDGCN() ? llvm::UndefValue::get(VarTy) + : llvm::Constant::getNullValue(VarTy),

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 created this revision. doru1004 added reviewers: ronl, carlo.bertolli, jhuber6, jdoerfert, dhruvachak, gregrodgers. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, nlopes, guansong, arichardson, yaxunl. Herald added a project: All. doru1004 requested review of this