[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane abandoned this revision. erichkeane added a comment. Superceded by https://reviews.llvm.org/D146178 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147722/new/ https://reviews.llvm.org/D147722 ___ cfe-commits mailing list

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane updated this revision to Diff 511753. erichkeane added a comment. Made changes as requested by Richard. "SkipForInstantiation" needed to be added when we added levels, but I think this is something that probably needs to be looked at and removed in the future. I also see the change

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. OK was able to create small(ish) repro main.h #include enum class Enums { ACCESS = 0, MAP = 1, }; template class DMap { public: template requires std::is_convertible_v void getOrCreate(TIDR v); }; template

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. I think it is probably a good idea to revert that one until you get a chance to figure out that problem (and #61993 if it is related!). Other than the test being dependent on your change (and perhaps failing without your change), this is otherwise unrelated, so I

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ChuanqiXu added a comment. In D147722#4250133 , @alexander-shaposhnikov wrote: > fwiw - I can revert https://reviews.llvm.org/D146178 for now till we fix the > newly discovered cases (at the moment I'm aware of GH61959 and the one > reported by

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. That would be great. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147722/new/ https://reviews.llvm.org/D147722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

alexander-shaposhnikov added a subscriber: ilya-biryukov. alexander-shaposhnikov added a comment. fwiw - I can revert https://reviews.llvm.org/D146178 for now till we fix the newly discovered cases (at the moment I'm aware of GH61959 and the one reported by @ilya-biryukov. Basically let me

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. With this patch here is still a build failure in our code base. I am trying to create a small repro. But from high level there is a templated class that has partial specializations, and it errors out on definition of a function that doesn't have any. CHANGES SINCE

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

rsmith added a comment. In D147722#4249612 , @erichkeane wrote: > Hmmm... the examples I thought would cause a problem don't seem to when > switching that to Done. So I'm going to run regression tests and give that a > shot. > > I think I now get

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. The switching that to 'done' seems to have broken cases where the partial specialization itself has requires clauses on it, see

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:291 /// encountering a lambda generic call operator, and continue looking for /// arguments on an enclosing class template. /* not directly related to this

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added a comment. Hmmm... the examples I thought would cause a problem don't seem to when switching that to Done. So I'm going to run regression tests and give that a shot. I think I now get what you mean about 'Identity' arguments, we basically need to have arguments to keep

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:322 + // they mean. + R = Response::UseNextDecl(PartialClassTemplSpec); } else if (const auto *ClassTemplSpec = erichkeane wrote: > rsmith wrote: > > Can we

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2854-2858 -template <> -bool DeducedArgsNeedReplacement( -ClassTemplatePartialSpecializationDecl *Spec) { - return !Spec->isClassScopeExplicitSpecialization(); -} rsmith

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2854-2858 -template <> -bool DeducedArgsNeedReplacement( -ClassTemplatePartialSpecializationDecl *Spec) { - return !Spec->isClassScopeExplicitSpecialization(); -} It's not

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane created this revision. erichkeane added reviewers: clang-language-wg, alexander-shaposhnikov. Herald added a project: All. erichkeane requested review of this revision. As reported in GH61959, the patch for https://reviews.llvm.org/D146178 regressed some comparisons of non-out-of-line