This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf799901c06c0: [Clang][Sema] Add
MultiLevelTemplateArgumentList::dump (authored by alexander-shaposhnikov).
Changed prior to commit:
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I'm happy with this, I think it is useful here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147744/new/
alexander-shaposhnikov added a comment.
for
template
struct X {
template
struct Y {
int f()
requires(I2 == 1)
{
return 1;
}
int f()
requires(I2 == 2)
{
return 1;
}
};
};
this would print the following:
alexander-shaposhnikov updated this revision to Diff 511551.
alexander-shaposhnikov added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147744/new/
https://reviews.llvm.org/D147744
Files:
rsmith added inline comments.
Comment at: clang/include/clang/Sema/Template.h:265
+
+LLVM_DUMP_METHOD void dump() const {
+ LangOptions LO;
I think it would be useful to also print out the number of retained outer
levels.
Repository:
rG LLVM Github
erichkeane added a comment.
Also, this prints backwards: it'll print 'inner to outer', but I suspect most
people will expect 'outer to inner'.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147744/new/
https://reviews.llvm.org/D147744
erichkeane added a comment.
I like the idea of this, this is really useful. Can you show what the output
looks like? It might be valuable to print the 'depth' before each list as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147744/new/
alexander-shaposhnikov created this revision.
alexander-shaposhnikov added reviewers: erichkeane, rsmith.
alexander-shaposhnikov created this object with visibility "All Users".
Herald added a project: All.
alexander-shaposhnikov requested review of this revision.
Herald added a project: clang.
