[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob added a comment. In D147779#4257212 , @PiotrZSL wrote: > arc land should work, I usually use arc patch --nobranch to check things > before committing and then git push. Hi @PiotrZSL, thank you for the help :) Repository: rG LLVM Github

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d20e329690: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks… (authored by dougpuob, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added a comment. arc land should work, I usually use arc patch --nobranch to check things before committing and then git push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob added a comment. Hi @PiotrZSL I do not have permission to land the change. Can you please help me to land this change? Another related question is that can I know how you land diffs? Take this diff as an example. Is it correct with `arc land --onto main --revision D147779`?

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

amurzeau accepted this revision. amurzeau added a comment. Thanks ! LGTM, nothing to add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 ___ cfe-commits

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob updated this revision to Diff 512021. dougpuob added a comment. - Improved suggestions in code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 Files:

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, except pointed out issues with order of fixes in release note and missing const. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:706 +size_t IdentifierNamingCheck::HungarianNotation::getAsteriskCount( +std::string , const NamedDecl *ND) const { + size_t PtrCount = 0; const

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob updated this revision to Diff 511969. dougpuob marked 2 inline comments as done. dougpuob added a comment. - Extract method - Remove template parameters in the getDeclTypeName() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob marked 2 inline comments as done. dougpuob added a comment. In D147779#4251081 , @PiotrZSL wrote: > Missing release notes. Thank you for reminding me. Comment at:

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added a comment. Missing release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:367-379 +if (const auto *TD = dyn_cast(ND)) { + QualType QT = TD->getType(); + + size_t PtrCount = 0; + if (QT->isPointerType()) { +

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix