[PATCH] D147839: [clang] Add test for CWG2007

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4beecef8f40: [clang] Add test for CWG2007 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512543. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147839/new/ https://reviews.llvm.org/D147839 Files: clang/test/CXX/drs/dr20xx.cpp clang/www/cxx_dr_status.html Index:

[PATCH] D147839: [clang] Add test for CWG2007

Endill added a comment. In D147839#4258681 , @shafik wrote: > In D147839#4257394 , @Endill wrote: > >> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary >> template instantiation

[PATCH] D147839: [clang] Add test for CWG2007

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you again for all the effort in documenting these and adding tests, it is much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

shafik added a comment. In D147839#4257394 , @Endill wrote: > Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary > template instantiation (presumably to find overloaded unary `&`), and make > Clang compliant since 3.4 Nice

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512365. Endill added a comment. Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary template instantiation (presumably to find overloaded unary `&`), and make Clang compliant since 3.4 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147839: [clang] Add test for CWG2007

shafik added inline comments. Comment at: clang/test/CXX/drs/dr20xx.cpp:20 +// FIXME: the following code shouldn't instantiate A. +// int b = ()->foo; +} Endill wrote: > shafik wrote: > > shafik wrote: > > > It looks like gcc and MSVC also instantiate `A` for

[PATCH] D147839: [clang] Add test for CWG2007

Endill added inline comments. Comment at: clang/test/CXX/drs/dr20xx.cpp:20 +// FIXME: the following code shouldn't instantiate A. +// int b = ()->foo; +} shafik wrote: > shafik wrote: > > It looks like gcc and MSVC also instantiate `A` for this case: > >

[PATCH] D147839: [clang] Add test for CWG2007

shafik added inline comments. Comment at: clang/test/CXX/drs/dr20xx.cpp:20 +// FIXME: the following code shouldn't instantiate A. +// int b = ()->foo; +} shafik wrote: > It looks like gcc and MSVC also instantiate `A` for this case: >

[PATCH] D147839: [clang] Add test for CWG2007

shafik added inline comments. Comment at: clang/test/CXX/drs/dr20xx.cpp:20 +// FIXME: the following code shouldn't instantiate A. +// int b = ()->foo; +} It looks like gcc and MSVC also instantiate `A` for this case: https://godbolt.org/z/8W8eYoa38 I have to

[PATCH] D147839: [clang] Add test for CWG2007

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2007 is resolved by skipping unqualified