[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/abbb22cc0c9c33dedb8d53c2bd3e703f92baace7. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Thank you! I'm going to fix this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list

[PATCH] D147920: [clang] Add test for CWG399

cor3ntin added a comment. I'm seeing test failures on main error: 'error' diagnostics expected but not seen: File /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/test/CXX/drs/dr3xx.cpp Line 1456: refers to a member in namespace File

[PATCH] D147920: [clang] Add test for CWG399

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Endill marked an inline comment as not done. Closed by commit rG14f245d01a1e: [clang] Add test for CWG399 (authored by Endill). Changed prior to commit:

[PATCH] D147920: [clang] Add test for CWG399

shafik accepted this revision. shafik added a comment. LGTM, apologies, it fell off my radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @shafik ping Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test aaron.ballman wrote: > aaron.ballman wrote: > > shafik wrote: > > > Endill wrote: > > > > shafik

[PATCH] D147920: [clang] Add test for CWG399

aaron.ballman accepted this revision. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test aaron.ballman

[PATCH] D147920: [clang] Add test for CWG399

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test shafik wrote: > Endill wrote: > > shafik

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @aaron.ballman ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > shafik wrote: > > Endill wrote: > > > Despite a couple of

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test shafik wrote: > Endill wrote: > > Despite a couple of FIXME in CWG244 test (out of dozens of examples), it

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. In D147920#4258680 , @shafik wrote: > In D147920#4257369 , @Endill wrote: > >> I think I haven't stressed it enough, but this whole test is copied from >> dr244, which is written by

[PATCH] D147920: [clang] Add test for CWG399

shafik added a comment. In D147920#4257369 , @Endill wrote: > I think I haven't stressed it enough, but this whole test is copied from > dr244, which is written by Richard. Understood, I appreciate the patience in explaining what I am missing.

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: aaron.ballman. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > Despite a couple of FIXME in CWG244 test (out of

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. I think I haven't stressed it enough, but this whole test is copied from dr244, which is written by Richard. Comment at: clang/test/CXX/drs/dr3xx.cpp:1492 +// This is technically ill-formed; G is looked up in 'N::' and is not found. +//

[PATCH] D147920: [clang] Add test for CWG399

shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1492 +// This is technically ill-formed; G is looked up in 'N::' and is not found. +// Rejecting this seems correct, but most compilers accept, so we do also. +f.N::F::~G(); // expected-error

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Despite a couple of FIXME in CWG244 test (out of dozens of examples), it claims full availability since

[PATCH] D147920: [clang] Add test for CWG399

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG399 is resolved by explicitly appealing to