This revision was automatically updated to reflect the committed changes.
Closed by commit rG32aaacc609e7: [clang-tidy] support nested inline namespace
in c++20 for modernize-concat… (authored by HerrCai0907).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
HerrCai0907 updated this revision to Diff 512541.
HerrCai0907 added a comment.
update acc. comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147946/new/
https://reviews.llvm.org/D147946
Files:
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM, just some style comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:84-86
+ Str.append(ND->getName());
+} else
+
HerrCai0907 updated this revision to Diff 512231.
HerrCai0907 added a comment.
fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147946/new/
https://reviews.llvm.org/D147946
Files:
HerrCai0907 updated this revision to Diff 512165.
HerrCai0907 added a comment.
remove lamda
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147946/new/
https://reviews.llvm.org/D147946
Files: