[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-11 Thread Congcong Cai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG32aaacc609e7: [clang-tidy] support nested inline namespace in c++20 for modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-11 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 512541. HerrCai0907 added a comment. update acc. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files:

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-11 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, just some style comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:84-86 + Str.append(ND->getName()); +} else +

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-10 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 512231. HerrCai0907 added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files:

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-10 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 512165. HerrCai0907 added a comment. remove lamda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files: