[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

bryanpkc added a comment. > May I ask you to commit the change? I do not have commit access. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b85bfffc486: [clang][tests] Fix Flang driver tests for Windows (authored by kaadam, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam added a comment. Bryan, thanks for the review. Is another acceptance required for merging? May I ask you to commit the change? I do not have commit access. Thanks, Adam CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___ cfe-commits mailing list

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam updated this revision to Diff 515717. kaadam added a comment. Updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 Files: clang/test/Driver/flang/flang.f90 clang/test/Driver/flang/flang_ucase.F90

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam added a comment. Yes, it could be. I will update them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___ cfe-commits mailing list

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

bryanpkc added a comment. `clang/test/Driver/flang/multiple-inputs-mixed.f90` uses a more general FileCheck pattern: ! CHECK-SYNTAX-ONLY-LABEL: "{{[^"]*}}flang-new{{[^"/]*}}" "-fc1" Perhaps these files should use the same regexp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam created this revision. kaadam added reviewers: kiranchandramohan, bryanpkc, mstorsjo. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added a project: All. kaadam requested review of this revision. Herald added a project: clang. Herald added a subscriber: