[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4324314 , @sousajo wrote: > have been sick, and could not advance much except I added the tests to > replicate the issue. Any ideas on how to proceed here? Sorry to hear you've been sick, but thank you for your

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. have been sick, and could not advance much except I added the tests to replicate the issue. Any ideas on how to proceed here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

thurston added a comment. Thanks Aaron and Jorge for the quick revert and replies! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276 ___ cfe-commits mailing

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. In D148276#4288236 , @aaron.ballman wrote: > In D148276#4288145 , @sousajo wrote: > >> hey :( I will try to investigate it a bit sometime next week ^^ thanks for >> pointing it out > >

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4288145 , @sousajo wrote: > hey :( I will try to investigate it a bit sometime next week ^^ thanks for > pointing it out Thank you for looking into it! I didn't think about `remove_const`, `remove_cv`, etc.

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. hey :( I will try to investigate it a bit sometime next week ^^ thanks for pointing it out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Reverted in 7f00ecd029213aee9baf297554b0cb25a5ffbd0f Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4287931 , @aaron.ballman wrote: > In D148276#4287900 , @thurston > wrote: > >> I think this change is triggering an error on a buildbot >>

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

aaron.ballman added a comment. In D148276#4287900 , @thurston wrote: > I think this change is triggering an error on a buildbot > (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): > > >

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

thurston added a comment. I think this change is triggering an error on a buildbot (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): /b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1348:45: error: cast from 'const

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c0021923503: [clang] trigger -Wcast-qual on functional casts (authored by sousajo, committed by aaron.ballman). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to