[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Sounds good, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

aaron.ballman added a comment. In D148439#4303202 , @kbobyrev wrote: > The difference is that `clang-rename` is a stand-alone binary with CLI > whereas `clangd` isn't typically used as such (it can be, but it's a weird > use-case). > > I don't know if

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. The difference is that `clang-rename` is a stand-alone binary with CLI whereas `clangd` isn't typically used as such (it can be, but it's a weird use-case). I don't know if there are any existing users out there, if there are then I assume there are very few. It was

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

aaron.ballman added a comment. In D148439#4299178 , @kbobyrev wrote: > Thanks Aaron! > > Yes, fair enough, that looks good to me, probably no need to move a sanity > check to the front of `main()` in this case. > > Also, just as a note: I don't know how

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Thanks Aaron! Yes, fair enough, that looks good to me, probably no need to move a sanity check to the front of `main()` in this case. Also, just as a note: I don't know how many people use `clang-rename` anymore (especially with `clangd` being present), I rewrote a

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4298606 , @aaron.ballman wrote: > LGTM, but please add a release note when landing the changes. Thanks for the review, added a release note for change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG62eec1584d2c: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Changed prior to commit:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, but please add a release note when landing the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. Ping for reivew. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:233 + if (!Entry) { +errs() << "clang-rename: input file does not exist.\n"; +return 1; kbobyrev wrote: > It is worth including the filename in the error

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514842. xgupta marked an inline comment as done. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Yeah, this should be a right approach! Thanks! Comment at: clang/test/clang-rename/NonExistFile.cpp:1 +// RUN: not clang-rename -offset=0 -new-name=plop asdasd

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272904 , @kbobyrev wrote: > Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file > is not really needed, most of the time the users of `clang-rename` (not sure > there are many with `clangd`

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514262. xgupta added a comment. adjust the return and add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/test/clang-rename/NonExistFile.cpp

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file is not really needed, most of the time the users of `clang-rename` (not sure there are many with `clangd` being developed) use CLI flags for that. It's better to revert this patch. My bad,

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272813 , @dyung wrote: > This change is also causing 33 test failures on a build bot > https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Yes, checking for the reason, and honestly I never tried to run

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. This change is also causing 33 test failures on a build bot https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272810 , @dyung wrote: > Is there a reason a test was not added with this change? Sorry, I missed that. Adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. Is there a reason a test was not added with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG726199146a0b: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Repository: rG

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; kbobyrev wrote: > Probably something like "input must

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514093. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/tools/clang-rename/ClangRename.cpp Index:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; Probably

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

vmiklos added subscribers: arphaman, klimek. vmiklos added a comment. Looks good to me, but probably you want an approval from @arphaman, @klimek or @kbobyrev before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta created this revision. xgupta added reviewers: vmiklos, alexander-shaposhnikov, kbobyrev, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-rename on a non existing file