[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-18 Thread Ilya Biryukov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccf719171937: [Modules] Do not rewrite existing decls when deserializing class fields (authored by ilya-biryukov). Repository: rG LLVM Github

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 514579. ilya-biryukov added a comment. - clang-format the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148515/new/ https://reviews.llvm.org/D148515 Files: clang/lib/AST/Decl.cpp

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-17 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148515/new/ https://reviews.llvm.org/D148515

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I plan to land this together with a reland of bc95f27337c7ed77c28e713c855272848f01802a and finally close GH61065 . I have checked this works

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Classes can have implicit members that were added before fields were