[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. In D148835#4288151 , @erichkeane wrote: > In D148835#4288148 , @cjdb wrote: > >> In D148835#4286924 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D148835#4288148 , @cjdb wrote: > In D148835#4286924 , @aaron.ballman > wrote: > >> In D148835#4286905 , @erichkeane >> wrote: >> >>> In

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D148835#4286924 , @aaron.ballman wrote: > In D148835#4286905 , @erichkeane > wrote: > >> In D148835#4284871 , @cjdb wrote: >> >>> I've had some

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D148835#4286905 , @erichkeane wrote: > In D148835#4284871 , @cjdb wrote: > >> I've had some very good input about why this probably shouldn't go ahead: >> git history erasure

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D148835#4284871 , @cjdb wrote: > I've had some very good input about why this probably shouldn't go ahead: git > history erasure :') While that is a common criticism, if we're going to do this at all, we should do it in

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-20 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb abandoned this revision. cjdb added a comment. I've had some very good input about why this probably shouldn't go ahead: git history erasure :') Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148835/new/ https://reviews.llvm.org/D148835

[PATCH] D148835: [clang] removes trailing whitespace

2023-04-20 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane, dblaikie. Herald added subscribers: luke, steakhal, bzcheeseman, kosarev, pmatos, asb, ormris, frasercrmck, jdoerfert, martong, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX,