[PATCH] D148914: [Sema][NFC] add check before using `BuildExpressionFromIntegralTemplateArgument`

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. See my comment on https://github.com/llvm/llvm-project/issues/62265 for results of my debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148914/new/ https://reviews.llvm.org/D148914

[PATCH] D148914: [Sema][NFC] add check before using `BuildExpressionFromIntegralTemplateArgument`

2023-04-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. This is the wrong fix here, the crash is appropriate here, else we're not getting the type right. For your example, we need to be setting up the template arguments

[PATCH] D148914: [Sema][NFC] add check before using `BuildExpressionFromIntegralTemplateArgument`

2023-04-21 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 created this revision. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch wants to avoid Sema crash for inline friend decl like template int foo(F1 X); template struct A {