cor3ntin added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:509-512
+ constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant expression}} \
+// expected-note {{cannot access base class of
pointer past the
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added subscribers: hubert.reinterpretcast, rsmith.
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:509-512
+ constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant expression}} \
+
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:509-512
+ constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant expression}} \
+// expected-note {{cannot access base class of
pointer past the end
cor3ntin added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:509-512
+ constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant expression}} \
+// expected-note {{cannot access base class of
pointer past the
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/AST/Interp/records.cpp:509-512
+ constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149013/new/
https://reviews.llvm.org/D149013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
13 matches
Mail list logo