This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa13f036949b0: [clang][Interp] Check one-past-the-end
pointers in GetPtrField (authored by tbaeder).
Changed prior to commit:
shafik added a subscriber: rsmith.
shafik added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:509
constexpr A *a2 = + 1; // expected-error {{must be initialized by a
constant expression}} \
// expected-note {{cannot access
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:500
namespace PointerArith {
struct A {};
shafik wrote:
> aaron.ballman wrote:
> > Neat! For the tests in this namespace, Clang and ICC agree, GCC and MSVC
> > agree, and
shafik added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:500
namespace PointerArith {
struct A {};
aaron.ballman wrote:
> Neat! For the tests in this namespace, Clang and ICC agree, GCC and MSVC
> agree, and users get to cry:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/test/AST/Interp/records.cpp:500
namespace PointerArith {
struct A {};
Neat! For the tests in this namespace,
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149149/new/
https://reviews.llvm.org/D149149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Rename CheckBaseDerived to something more
