This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61976af3ba93: [clang][driver] Enable MisExpect diagnostics
flag outside of CC1 (authored by paulkirth).
Repository:
rG LLVM Github Monorepo
hans accepted this revision.
hans added a comment.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149206/new/
https://reviews.llvm.org/D149206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
paulkirth added inline comments.
Comment at: clang/test/Driver/clang_f_opts.c:144
+// RUN: %clang -### -S -fprofile-instr-use=%t.profdata
-fdiagnostics-misexpect-tolerance=10 -Wmisexpect %s 2>&1 | FileCheck %s
--check-prefix=CHECK-MISEXPECT-TOLLERANCE
+//
paulkirth updated this revision to Diff 517243.
paulkirth marked an inline comment as done.
paulkirth added a comment.
Update test to check if the flag is in cc1, instead of just looking for a
warning.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hans added inline comments.
Comment at: clang/test/Driver/clang_f_opts.c:144
+// RUN: %clang -### -S -fprofile-instr-use=%t.profdata
-fdiagnostics-misexpect-tolerance=10 -Wmisexpect %s 2>&1 | FileCheck %s
--check-prefix=CHECK-MISEXPECT-TOLLERANCE
+//
paulkirth updated this revision to Diff 517199.
paulkirth added a comment.
Migrate to a Driver test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149206/new/
https://reviews.llvm.org/D149206
Files:
clang/lib/Driver/ToolChains/Clang.cpp
paulkirth added inline comments.
Comment at: clang/test/Profile/misexpect-branch.c:10
// RUN: %clang_cc1 %s -O2 -o - -emit-llvm
-fprofile-instrument-use-path=%t.profdata -verify=foo
-fdiagnostics-misexpect-tolerance=10 -Wmisexpect
-debug-info-kind=line-tables-only
+// RUN:
hans added inline comments.
Comment at: clang/test/Profile/misexpect-branch.c:10
// RUN: %clang_cc1 %s -O2 -o - -emit-llvm
-fprofile-instrument-use-path=%t.profdata -verify=foo
-fdiagnostics-misexpect-tolerance=10 -Wmisexpect
-debug-info-kind=line-tables-only
+// RUN: %clang
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149206/new/
https://reviews.llvm.org/D149206