[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ba1c12fcc: [Clang] Fix parsing of `(auto(x))`. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 ___ cfe-commits mailing list

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 523729. cor3ntin added a comment. Address Aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:2178-2182 +// When parsing an identifier after an arrow +// it may be a member expression, in which case we +// should not annotate it as an independant expression +// so we just lookup that

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522979. cor3ntin added a comment. - When tentative parse an abstract declarator whithout auto specifier, do not classify it as a declaration based on the presence of arrow - When tentative parse a declarion vs member access, do not annotate the token after

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. @kadircet thanks for letting me know, I'm investigating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

kadircet added a comment. hi! this seem to have regressed compilation for some valid C++ code: struct Bar { const char *name(); }; struct Baz { static Bar *method(); }; struct Foo { Foo(const char *); }; template void bar() { Foo _(T::method()->name()); } void

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef47318ec361: [Clang] Fix parsing of `(auto(x))`. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522180. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D149276#4341552 , @cor3ntin wrote: > @aaron.ballman this won;t get approve by core un > > In D149276#4302700

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. @aaron.ballman this won;t get approve by core un In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4305780 , @shafik wrote: > I see that we do have an issue but so far the examples in the tests don't > feel very natural and so I would like to understand if there is a larger > motivation here. The context is that

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

shafik added a comment. I see that we do have an issue but so far the examples in the tests don't feel very natural and so I would like to understand if there is a larger motivation here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a subscriber: rsmith. cor3ntin added a comment. @rsmith @hubert.reinterpretcast do you see any reason not to go ahead with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG changes their mind and picks a different >

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman edited reviewers, added: hubert.reinterpretcast, clang-language-wg; removed: jdoerfert. aaron.ballman added a comment. The changes generally LGTM, but: > in a way consistent with the proposed resolution to CWG1223. What are the chances that CWG changes their mind and picks a

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517536. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1067 +bool mayHaveDirectInit, +bool mayHaveTrailingReturnType) { // declarator: tbaeder

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:237 ConsumeAnnotationToken(); -if (Tok.is(tok::identifier)) +if (Tok.isOneOf(tok::identifier, tok::kw_auto)) ConsumeToken(); aaron.ballman wrote: > This smells a

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1067 +bool mayHaveDirectInit, +bool mayHaveTrailingReturnType) { // declarator: Not part of

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517491. cor3ntin added a comment. Do not parse auto( as an expression before C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files:

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517488. cor3ntin marked 8 inline comments as done. cor3ntin added a comment. - Fix tests - Address aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:360 (`#61336 `_) +- Fix parsing of `auto(x)`, when it is surrounded by parenthesese. Comment at:

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517248. cor3ntin added a comment. Fix whitespace only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Allow auto(x) to appear in a parenthesis expression. The pattern