[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-09-23 Thread Null Yang via Phabricator via cfe-commits
AlexYzhov added a comment. Add command without backend wrapper destroys the compatibility to different linkers. Some people will use gcc driver instead of ld/lld itself as linker, a "-Wl," prefix is needed in this situation. i've met familiar issue that corrupts the link step:

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024bb62ffd07: [Driver] Pass --target2= to linker from baremetal toolchain (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149458/new/ https://reviews.llvm.org/D149458 ___ cfe-commits mailing list

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Peter Smith via Phabricator via cfe-commits
peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM. This is consistent with the target2 support that I added to LLD several years ago in https://reviews.llvm.org/D25684 will be good to give some time for other reviewers to add

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: peter.smith, phosek, michaelplatings. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. miyuki requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.