This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGca9683651e52: [Sema] `setInvalidDecl` for error deduction
declaration (authored by HerrCai0907).
Repository:
rG LLVM Github Monorepo
CHANGES
HerrCai0907 updated this revision to Diff 524849.
HerrCai0907 added a comment.
format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
clang/docs/ReleaseNotes.rst
HerrCai0907 updated this revision to Diff 524824.
HerrCai0907 added a comment.
add std option
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
clang/docs/ReleaseNotes.rst
HerrCai0907 reopened this revision.
HerrCai0907 added a comment.
This revision is now accepted and ready to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
TWeaver added a comment.
The build bot failures have been going for a while now so I've had to revert
this until the author can address them, my apologies.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
dyung added a comment.
Hi @HerrCai0907, this change is failing on the PS4 linux and PS5 Windows bot.
Can you take a look? I'm guessing these failures are likely due to the PS4/PS5
target defaulting to a different C/C++ standard than the rest of clang.
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeb5902ffc971: [Sema] `setInvalidDecl` for error deduction
declaration (authored by HerrCai0907).
Repository:
rG LLVM Github Monorepo
CHANGES
HerrCai0907 updated this revision to Diff 524582.
HerrCai0907 added a comment.
update comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
clang/docs/ReleaseNotes.rst
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a request for a comment.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11196
if (D.isFunctionDefinition())
Diag(D.getIdentifierLoc(),
HerrCai0907 added a comment.
@rsmith could you review it again?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
___
cfe-commits mailing list
HerrCai0907 added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
HerrCai0907 added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
HerrCai0907 added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
HerrCai0907 updated this revision to Diff 519847.
HerrCai0907 added a comment.
return Diag
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
clang/docs/ReleaseNotes.rst
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11141-11145
if (!Chunk.Fun.hasTrailingReturnType()) {
+ IsValid = false;
Diag(D.getName().getBeginLoc(),
diag::err_deduction_guide_no_trailing_return_type);
break;
HerrCai0907 added a comment.
ping @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
HerrCai0907 marked 2 inline comments as done.
HerrCai0907 added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11196
if (D.isFunctionDefinition())
Diag(D.getIdentifierLoc(), diag::err_deduction_guide_defines_function);
+ return IsValid;
HerrCai0907 updated this revision to Diff 518403.
HerrCai0907 marked an inline comment as done.
HerrCai0907 added a comment.
refactor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
rsmith added a comment.
I wonder if there are any cases where the "deduction guide" is so broken that
we shouldn't be creating a `CXXDeductionGuideDecl` at all. For example, if
there's no trailing return type, then the declaration is syntactically invalid
(and looks more like a constructor
shafik added a comment.
Thank you for the fix.
I have some questions, why don't we always call `CheckDeductionGuideDeclarator`
when calling `CXXDeductionGuideDecl::Create`, I felt like perhaps
`CheckDeductionGuideDeclarator` should be rolled into
`CXXDeductionGuideDecl::Create` but then I
HerrCai0907 updated this revision to Diff 518155.
HerrCai0907 added a comment.
add release note
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149516/new/
https://reviews.llvm.org/D149516
Files:
clang/docs/ReleaseNotes.rst
HerrCai0907 created this revision.
Herald added a project: All.
HerrCai0907 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixed: https://github.com/llvm/llvm-project/issues/62408
`setInvalidDecl` for invalid `CXXDeductionGuideDecl` to
22 matches
Mail list logo
