[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4342320 , @Manna wrote: > In D149718#4341384 , @uabelho wrote: > >> In D149718#4341052 , @uabelho >> wrote: >> >>> Compiling with

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4341384 , @uabelho wrote: > In D149718#4341052 , @uabelho wrote: > >> Compiling with clang 15.0.5 I get the following warning/error with this >> patch: >> >>

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4341052 , @uabelho wrote: > Compiling with clang 15.0.5 I get the following warning/error with this patch: > > ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly > defaulted move assignment

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. Compiling with clang 15.0.5 I get the following warning/error with this patch: ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] AttributePool

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ebff1ac1b98: [NFC][Clang] Fix Coverity issues of copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4333563 , @tahonermann wrote: > Looks good. Thanks @Manna! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good. Thanks @Manna! Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &); +SemaDiagnosticBuilder

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &); +SemaDiagnosticBuilder =(SemaDiagnosticBuilder &); SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default;

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 521073. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &); +SemaDiagnosticBuilder

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna marked 6 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:704 /// Move the given pool's allocations to this pool. AttributePool(AttributePool &) = default; tahonermann wrote: > This class has a

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 520384. Manna added a comment. Thanks @tahonermann for reviews. I have addressed review comments and updated patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files:

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks good with one exception; I think the changes for class `SemaDiagnosticBuilder` are not what was intended. Comment at:

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 519331. Manna added a comment. Fix clang-format errors and typo in comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna created this revision. Manna added a reviewer: tahonermann. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the class which has user-defined copy/move