[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4f96290ac9: [Clang][M68k] Add Clang support for the new

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added a comment. Posting on GitHub loses all context; please don't do that. Whose review are you looking for? You've addressed my feedback and you had approval from Aaron on the prior version, with the latest version just being a few minor tweaks to address the couple of comments I had

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Maybe these patches need to be reposted to Github as they seem to be ignored here now after the swtich from Phabricator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

0x59616e added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Any news on this? I guess it would be nice to get the remaining m68k patches merged before the Phrabricator shutdown. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. In D149867#4612589 , @myhsu wrote: > In D149867#4603853 , @aaron.ballman > wrote: > >> In D149867#4544489 , @myhsu wrote: >> >>> Sorry I was

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4603853 , @aaron.ballman wrote: > In D149867#4544489 , @myhsu wrote: > >> Sorry I was busy on my phd defense (which I passed!) in the past month. I'll >> get back to this next

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:10 +// X86: call x86_stdcallcc i32 @bar( +#ifndef mc68000 bar(arg); jrtc27 wrote: > Uh, this shouldn't be defined in ISO C; GCC's using builtin_define_std, so > you should only get

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 552596. myhsu marked 2 inline comments as done. myhsu added a comment. Addressed comments in `test/CodeGen/mrtd.c` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added inline comments. Comment at: clang/test/CodeGen/mrtd.c:2 +// RUN: %clang_cc1 -mrtd -triple i386-unknown-unknown -std=c89 -emit-llvm -o - %s 2>&1 | FileCheck --check-prefixes=CHECK,X86 %s +// RUN: %clang_cc1 -mrtd -triple m68k-unknown-unknown -std=c89 -emit-llvm -o

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149867#4544489 , @myhsu wrote: > Sorry I was busy on my phd defense (which I passed!) in the past month. I'll > get back to this next week. Congratulations!!  LGTM!

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/Sema/m68k-mrtd.c:4-9 +#ifdef MRTD +// expected-error@+3 {{function with no prototype cannot use the m68k_rtd calling convention}} +#endif +void foo(int arg) { + bar(arg); +} aaron.ballman wrote: > myhsu

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 551797. myhsu marked 4 inline comments as done. myhsu added a comment. - Add more C++ tests for `m68k_rtd`, both Sema and CodeGen ones - Addressed other comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4544281 , @glaubitz wrote: > Any update on this? Sorry I was busy on my phd defense (which I passed!) in the past month. I'll get back to this next week. CHANGES SINCE LAST ACTION

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman added a comment. Also, it looks like precommit CI found a relevant failure that should be investigated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman added a comment. Sorry for the long delay in review on this, it slipped through the cracks for me. Comment at: clang/lib/AST/TypePrinter.cpp:1861 break; + case attr::M68kRTD: OS << "m68k_rtd"; break; case attr::NoDeref:

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:559 +emitError |= DefaultCC == LangOptions::DCC_StdCall && + Arch != llvm::Triple::m68k && Arch != llvm::Triple::x86; emitError |= (DefaultCC ==

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 532423. myhsu marked 5 inline comments as done. myhsu edited the summary of this revision. myhsu added a comment. Herald added a subscriber: MaskRay. - Add a new default calling convention `-fdefault-calling-conv=rtdcall` to model using `m68k_rtdcc` globally -

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman added a comment. This should also come with a release note for the changes. Comment at: clang/lib/AST/ASTContext.cpp:11998-11999 + return CC_X86StdCall; +else if (T.getArch() == llvm::Triple::m68k) + return CC_M68kRTD; + }

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu marked 3 inline comments as done. myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:4 -// CHECK: mrtd.c:10:3: warning: function with no prototype cannot use the stdcall calling convention +// CHECK: mrtd.c:13:3: warning: function with no prototype

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 530089. myhsu retitled this revision from "[M68k] Add Clang support for the new M68k_RTD CC" to "[Clang][M68k] Add Clang support for the new M68k_RTD CC". myhsu edited the summary of this revision. myhsu set the repository for this revision to rG LLVM Github