[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

martell added a comment. It won't let me revert the automatically updated diff to the previous one because I am not the author. @faisalv are you able todo this and Sorry for the confusion. Repository: rL LLVM https://reviews.llvm.org/D15005 ___

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

martell added a comment. In case anyone comes here looking for https://reviews.llvm.org/rL300555 that should be https://reviews.llvm.org/D15006 no https://reviews.llvm.org/D15005. Thanks Repository: rL LLVM https://reviews.llvm.org/D15005 ___

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

This revision was automatically updated to reflect the committed changes. Closed by commit rL300555: Driver: Better detection of mingw-gcc (authored by martell). Changed prior to commit: https://reviews.llvm.org/D15005?vs=41206=95568#toc Repository: rL LLVM https://reviews.llvm.org/D15005

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv added a comment. *ping* http://reviews.llvm.org/D15005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv added a comment. *ping* http://reviews.llvm.org/D15005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

majnemer added a subscriber: majnemer. Comment at: lib/Sema/SemaTemplate.cpp:528 @@ +527,3 @@ +[, this](const TemplateArgument ) { +if (const bool IsFirst = !StringifiedTemplateArgs.size()) + StringifiedTemplateArgs = "<"; You could use

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:528 @@ +527,3 @@ +[, this](const TemplateArgument ) { +if (const bool IsFirst = !StringifiedTemplateArgs.size()) + StringifiedTemplateArgs = "<"; majnemer wrote: > You

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a subscriber: cfe-commits. Clang currently does no real checking of the template argument list when a template-id is used to declare a constructor: template struct X { X(); // Clang erroneously accepts this.