martell added a comment.
Committed as https://reviews.llvm.org/rL300555
Repository:
rL LLVM
https://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 accepted this revision.
mati865 added a comment.
This revision is now accepted and ready to land.
Looks fine for MinGW on Windows.
Repository:
rL LLVM
https://reviews.llvm.org/D15006
___
cfe-commits mailing list
yaron.keren added reviewers: mati865, rnk.
yaron.keren added a comment.
Adding Mateusz and Reid.
Repository:
rL LLVM
https://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martell added a comment.
To clarify the most import part about actually being able to test this is the
being able to modify the PATH variable for windows and unix hosts in the test
case.
The program prefix is less of a problem because I can double down with the same
empty file one with .exe
martell updated this revision to Diff 95292.
martell edited the summary of this revision.
martell added a reviewer: yaron.keren.
martell added a subscriber: yaron.keren.
martell added a comment.
After the revert I left this patch go to pick up some other patch work.
Seen as we are not anywhere
ismail added a comment.
Reverted in r257468.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM with some tests cases.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martell updated this revision to Diff 42933.
martell added a comment.
Sorry I was a bit slow getting around to this.
Will do testcases if Yaron thinks this is okay
http://reviews.llvm.org/D15006
Files:
lib/Driver/MinGWToolChain.cpp
lib/Driver/ToolChains.h
Index: lib/Driver/ToolChains.h
ismail added a comment.
Martell, any update on this?
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell added a comment.
hi ismail,
I will tidy up for review closer towards the weekend where i can work on out of
work stuff
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ismail added a comment.
Tested on openSUSE and it works. Thanks!
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
findGccDir() can return llvm::ErrorOr and then all Base
assignments happen at the same if-elseif-else:
if (getDriver().SysRoot.size())
Base = getDriver().SysRoot;
else if (llvm::ErrorOr GPPName = findGccDir())
Base = llvm::sys::path::parent_path(
martell added a comment.
@ismail can you test this for your setup please? :)
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell updated the summary for this revision.
martell updated this revision to Diff 41208.
martell added a comment.
Removed the break that I didn't think was needed
Can be re-added ??
Will added testcases
http://reviews.llvm.org/D15006
Files:
lib/Driver/MinGWToolChain.cpp
Index:
martell updated this revision to Diff 41209.
martell added a comment.
Updated to reflect feedback
I'm not too sure what todo for testcases on this one because they already exist
for the most part.
I ran the test suite and they all pass.
I would have to create a mingw32-gcc and
yaron.keren added a comment.
This always searches for something-gcc and then discards the result if sysroot
was provided, which is a waste.
Move the searching to a helper function and then it can be done only if sysroot
was not provided, as it is now.
The break is needed to avoid looking for
16 matches
Mail list logo
