[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs abandoned this revision. codemzs added a comment. Closing this as it has been resolved by D150913 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 ___

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4338118 , @tahonermann wrote: >> I do wonder if we need two bfloat implementations, but for that I'll leave a >> comment on D149573 . > > Given the discussions occurring in D149573

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. > I do wonder if we need two bfloat implementations, but for that I'll leave a > comment on D149573 . Given the discussions occurring in

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

stuij accepted this revision. stuij added a comment. Regarding this particular change, we at Arm are happy with the name change. I saw BFloat16 instead of BF16 as tech debt that we didn't get round to fixing. I do wonder if we need two bfloat implementations, but for that I'll leave a comment

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4335352 , @tahonermann wrote: > Thanks for all the updates @codemzs! I'm going to go ahead and accept. But > please wait a few days for recently subscribed folks to have a chance to > comment before landing this.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521363. codemzs marked an inline comment as done. codemzs added a comment. Addressing feedback from @barannikov88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 Files: clang/include/clang-c/Index.h

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. In D150291#4335414 , @codemzs wrote: > I've provided the git log message that I see on my end below. I ensured that > it is split into multiple lines, with each line not exceeding the character > limit. Please let me know

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs marked an inline comment as done. codemzs added a comment. In D150291#4335360 , @barannikov88 wrote: > The summary as it is will be hard to read in git log. Please split it into > multiple lines 72~80 chars each. >

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. The summary as it is will be hard to read in git log. Please split it into multiple lines 72~80 chars each. https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks for all the updates @codemzs! I'm going to go ahead and accept. But please wait a few days for recently subscribed folks to have a chance to comment before landing this.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added inline comments. Comment at: clang/lib/AST/Type.cpp:2187 + BT->getKind() <= BuiltinType::Ibm128 && + BT->getKind() != BuiltinType::BF16; if (const auto *ET = dyn_cast(CanonicalType)) Looks like another clang-format

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521353. codemzs marked 2 inline comments as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Update comments as per feedback from @tahonermann Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added a subscriber: clang-vendors. tahonermann added a comment. Heads up @clang-vendors. This patch changes the names of many internal identifiers for enumerators, class data members, and functions (including virtual functions) that are related to support for the `__bf16` type. The

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added subscribers: lenary, foad. tahonermann added a comment. > I was following the LLVM contribution guidelines to use git clang-format, but > I understand the importance of maintaining existing code styles that may be > altered by git-clang format. The guidelines are slightly in

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. Thank you for pointing that out and for reviewing my code. I appreciate your guidance. I was following the LLVM contribution guidelines to use git clang-format, but I understand the importance of maintaining existing code styles that may be altered by git-clang format.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521163. codemzs marked 4 inline comments as done. codemzs retitled this revision from "[Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`" to "[Clang] Rename internal type identifier(s) for __bf16 to BF16Ty". codemzs added a comment. PR

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks great, thank you for doing this! Requested changes are just to undo some of the style changes. Comment at:

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

codemzs created this revision. codemzs added reviewers: tahonermann, erichkeane, stuij. Herald added subscribers: mattd, gchakrabarti, asavonic, ctetreau, kerbowa, arphaman, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subscribers: