[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added a comment. In D150490#4343442 , @craig.topper wrote: > In D150490#4343145 , @enh wrote: > >> In D150490#4343128 , @hiraditya >> wrote: >> Is there

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. In D150490#4343145 , @enh wrote: > In D150490#4343128 , @hiraditya > wrote: > >>> Is there more context on why Android enables the frame pointer? >> >> From what i gathered, this is

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added a comment. In D150490#4343128 , @hiraditya wrote: >> Is there more context on why Android enables the frame pointer? > > From what i gathered, this is more of an effort to have parity such that > existing build flag overrides continue to be

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added a comment. > Is there more context on why Android enables the frame pointer? From what i gathered, this is more of an effort to have parity such that existing build flag overrides continue to be consistent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 522252. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf98698714e2e: Enable frame pointer for all non-leaf functions on riscv64 Android (authored by AdityaK 1894981+hiradi...@users.noreply.github.com).

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP ||

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh accepted this revision. enh added a comment. This revision is now accepted and ready to land. (lgtm with craig.topper's suggested simplification.) Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE()

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:530 + Triple.isAArch64() || Triple.isPS() || Triple.isVE() || + (Triple.isAndroid() && (Triple.getArch() == llvm::Triple::riscv64))); if (NoOmitFP ||

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. Is there more context on why Android enables the frame pointer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521835. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { hiraditya wrote: > enh wrote: > > (where? is

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { enh wrote: > (where? is it simpler to just add

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { (where? is it simpler to just add arm64 to the

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521826. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:423 + if (Triple.isAndroid() && Triple.getArch() == llvm::Triple::riscv64) +return true; should this... Comment at: clang/lib/Driver/ToolChains/Clang.cpp:439

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya created this revision. hiraditya added reviewers: enh, danalbert, pirama, srhines. Herald added subscribers: VincentWu, danielkiss, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. hiraditya