shafik added inline comments.
Comment at: clang/lib/Sema/SemaConcept.cpp:783
return true;
- if (Old && New && Old != New) {
+ if (Old && New && Old != New &&
+ Old->getLexicalDeclContext() != New->getLexicalDeclContext()) {
shafik wrote:
> erichkeane
This revision was automatically updated to reflect the committed changes.
Closed by commit rG122b938944ce: [Clang][Sema] Substitute constraints only for
declarations with different… (authored by alexander-shaposhnikov).
Changed prior to commit:
shafik added inline comments.
Comment at: clang/lib/Sema/SemaConcept.cpp:783
return true;
- if (Old && New && Old != New) {
+ if (Old && New && Old != New &&
+ Old->getLexicalDeclContext() != New->getLexicalDeclContext()) {
erichkeane wrote:
> Please
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
No release note needed, as this is a regression, but thanks for putting this
together!
Comment at: clang/lib/Sema/SemaConcept.cpp:783
return true;
- if (Old
alexander-shaposhnikov updated this revision to Diff 522856.
alexander-shaposhnikov added a comment.
Include context.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150730/new/
https://reviews.llvm.org/D150730
Files:
shafik added a comment.
Can you please add context to the diff. thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150730/new/
https://reviews.llvm.org/D150730
___
cfe-commits mailing list
alexander-shaposhnikov created this revision.
alexander-shaposhnikov added a reviewer: erichkeane.
alexander-shaposhnikov created this object with visibility "All Users".
Herald added a project: All.
alexander-shaposhnikov requested review of this revision.
Herald added a project: clang.
Herald
