This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rG3bc1ea5b0ac9: [clang][dataflow] Fix a bug in handling of
`operator-` for optional checker. (authored by
mboehme marked 2 inline comments as done.
mboehme added inline comments.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789
- // of these accessors.
- .CaseOfCFGStmt(valueOperatorCall(std::nullopt),
ymandel added inline comments.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789
- // of these accessors.
- .CaseOfCFGStmt(valueOperatorCall(std::nullopt),
[](const CallExpr *E,
mboehme added inline comments.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789
- // of these accessors.
- .CaseOfCFGStmt(valueOperatorCall(std::nullopt),
[](const CallExpr *E,
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Nice catch!
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789
- // of these accessors.
-
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Prior to this patch, `operator->` was being
