[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

sammccall added a comment. I'd be more comfortable reviewing this after it's actually been added to the style guide, it's hard to refer to non-public docs and discussions here. I don't really understand the rationale for the hard split into two modes, vs always accepting both styles and maybe

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel marked 3 inline comments as done. ymandel added a comment. Thank you for the very fast review! Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97 : ClangTidyCheck(Name, Context), + UseV2Style(Options.getLocalOrGlobal("UseV2Style",

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel updated this revision to Diff 523440. ymandel added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150872/new/ https://reviews.llvm.org/D150872 Files:

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97 : ClangTidyCheck(Name, Context), + UseV2Style(Options.getLocalOrGlobal("UseV2Style", false)), Handler(std::make_unique( Given this check is

[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

ymandel created this revision. ymandel added a reviewer: sammccall. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Google style is