This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa62e205254c0: [clang][RecoveryExpr] Fix a crash where a
dependent type crahes on c-only code… (authored by hokein).
Repository:
rG LLVM Github
hokein added a comment.
Thanks for the fast review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150948/new/
https://reviews.llvm.org/D150948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein updated this revision to Diff 523868.
hokein added a comment.
add release note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150948/new/
https://reviews.llvm.org/D150948
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaDecl.cpp
shafik accepted this revision.
shafik added a comment.
Thank you for the fix, LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150948/new/
https://reviews.llvm.org/D150948
___
cfe-commits mailing list
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but this should have a release note for the fix. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150948/new/
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
A depenent type is possible in C-only path, add a proper handling when
checking the enum constant.
Fixes
